Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-table): Fix error Unknown event handler property onCollapse. #2195

Merged
merged 1 commit into from
Jun 10, 2019
Merged

fix(react-table): Fix error Unknown event handler property onCollapse. #2195

merged 1 commit into from
Jun 10, 2019

Conversation

kunyan
Copy link
Contributor

@kunyan kunyan commented Jun 10, 2019 •
edited

What:

Remove rows and onCollapse from ..props

The recently collapse changes added some unknown props of table
Just remove it from ..props

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2195-pr-patternfly-react-patternfly.surge.sh

@priley86
Copy link
Member

priley86 commented Jun 10, 2019 •
edited

@kunyan thanks - i knew about this and was going to submit a fix today. Looks like you beat me to it ;)

Slight miss during rebase of latest eslint...

@priley86
Copy link
Member

@kunyan do you mind updating snapshots yarn test:pf4 -u ?

@codecov-io
Copy link

codecov-io commented Jun 10, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@a3e5de0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2195   +/-   ##
=========================================
  Coverage          ?   80.45%           
=========================================
  Files             ?      660           
  Lines             ?     8343           
  Branches          ?      641           
=========================================
  Hits              ?     6712           
  Misses            ?     1331           
  Partials          ?      300
Flag Coverage Δ
#patternfly3 85.22% <ø> (?)
#patternfly4 75.78% <100%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...-4/react-table/src/components/Table/BodyWrapper.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e5de0...da2b520. Read the comment docs.

@kunyan
Copy link
Contributor Author

kunyan commented Jun 10, 2019

Snapshots updated, but looks CI not updated

@redallen
Copy link
Contributor

Travis isn't reporting it's status, but the build passed: https://travis-ci.org/patternfly/patternfly-react/builds/543763403

@redallen redallen merged commit 2cbdfb8 into patternfly:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priley86 priley86 priley86 approved these changes

@redallen redallen redallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kunyan @patternfly-build @priley86 @codecov-io @redallen